NW6 | Hadika Malik | HTML-CSS | Module-Project | Week 1 + Week 2 #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bunday
suggested changes
Oct 5, 2023
css/style.css
Outdated
| justify-content: center; | ||
| } | ||
|
|
||
| /* .container{ |
There was a problem hiding this comment.
Hi, as best practice, its better to remove code sections you are not using, instead of commenting it out
|
|
||
| </section> | ||
| </main> | ||
| <hr> |
There was a problem hiding this comment.
the color for this element is a bit different
| <section class="main"> | ||
| <h1>Introducing Karma</h1> | ||
| <p>Bring WiFi with you, everywhere you go.</p> | ||
| <button class="orange-button">Learn More</button> |
There was a problem hiding this comment.
this class orange-button doesnt exist in your css, you can remove unused classes. Also, this button seems to have a border width on it, can you remove it?
index.html
Outdated
| <nav> | ||
| <ul class="navigation_list"> | ||
| <li class="navigation_item"> | ||
| <a class="navigation_link" href="#">Meet Karma</a> |
bunday
suggested changes
Oct 11, 2023
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> | ||
| <title><Form></Form></title> |
HadikaMalik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
writing the html
What did you find hard?
sorting the layout out and getting the fonts and colours right
What do you still not understand?
the layout of the header, the three images and how it changes when zooming in or out
Any other notes?