Skip to content

NW6|Fidaa Bashir|HTML-CSS|Module-Project|week 1 #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NW6|Fidaa Bashir|HTML-CSS|Module-Project|week 1 #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 104 additions & 2 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

/* We are using the 'Roboto' font from Google. This has already been added to your HTML header */
/* We are using the 'Roboto' font from Google. This has already been added to your HTML header */

body {
font-family: 'Roboto', sans-serif;
Expand All @@ -16,4 +15,107 @@ body {
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/

.header,
.ma-img,
.footer,
.icon{
padding: 0 1.5rem;
max-width: auto;
margin: 0 auto;
}
.header{
display: flex;
align-items: center;
justify-content: space-between;
height: 5rem;
margin-bottom: 1rem;
padding-top: 1rem;
}
nav{
display: flex;
width: 100%;
}
.navbar{
display: flex;
list-style: none;
font-size: normal;
color: lightgrey;
padding-left: 8rem;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header is more to the left than it should be, should be right aligned as shown in the picture of the sample site
image


}
.nav-li-a{
margin: 20px;
text-decoration: none;
color: gray;
}

.karma-logo{
max-height: 40px;
width: auto;
padding-right: 10rem;
}
.meet{
font-weight: bold;
}
.Store{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small niggle, but it's worth thinking about. You're using a captial letter in this classname, and you've done it nowhere else. This can be annoying as CSS is case senstive so easy to make a mistake. It's up to you though what you want to do

color: orange;
}

.ma-img{
display: flex;
background-image: url( "/img/first-background.jpg");
height: 500px;
background-size: cover;
color: white;
flex-direction: column;
justify-content: center;
align-items: center;
}
.learn-more{
background-color: rgb(235, 114, 66);
border-radius: 10px;
padding: 10px 20px;
margin-bottom: 5rem;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Button is a bit off I'm afraid. Has a white border and the border-radius is too big so it's more rounded than it outght to be

}
.icon-img{
max-height: 100px;
width: auto;
padding-bottom: 4rem;
flex-direction: row;
}
.p2{
margin-bottom: 3rem;
}
.icon{
display: flex;
justify-content:space-around;
}
.line{
color:#DCDCDC;
}
.icon-footer1{
max-height: 20px;
justify-content: center;
border: solid 1px rgb(224, 229, 229);
border-radius: 15px;
margin-left: 30px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the picture, the icons had a bit more space around them - they weren't touching the border

}
.footer,
.part2{
text-align: center;
}
.p1,
.part2{
text-align: center;
font-size: 40px;
}
.p1{
margin-bottom: 1rem;
}
.footer-p{
font-weight: bold;
}
.copyrights{
color: grey;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe test on this is very small and almost unreadable for me so would make a bit bigger

font-size: x-small;
}
54 changes: 51 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,67 @@
<!DOCTYPE html>
<html lang="en">

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
<title>Karma</title>
<link href='https://fonts.googleapis.com/css?family=Roboto:400,500,300' rel='stylesheet' type='text/css'>
<link rel="stylesheet" href="css/normalize.css">
<link rel="stylesheet" href="css/style.css">
<link rel="shortcut icon" type="image/x-icon" href="favicon.ico">
<link rel="shortcut icon" type="image/x-icon" href="favicon.ico">
</head>

<body>

<!-- Add your HTML markup here -->
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<!-- All the images you need are in the 'img' folder -->

<header class="header"><img class="karma-logo" src="./img/karma-logo.svg" alt="karma-logo">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No massive complants on the HTML here: good use of sematic HTML, tags have alt attrs, would say that the naming convensions could be better: nav-liwould maybe make more sense as nav-item but this is about developing your style :)

<nav class="nav">
<ul class="navbar">
<li class="nav-li"> <a class= "nav-li-a" href= "#"><span class="meet">Meet Karma</span></a></li>
<li class="nav-li"> <a class= "nav-li-a" href= "#">How it work</a></li>
<li class="nav-li"> <a class= "nav-li-a" href="#"><span class="Store">Store</span></a></li>
<li class="nav-li"> <a class= "nav-li-a" href= "#">Blog</a></li>
<li class="nav-li"> <a class= "nav-li-a" href= "#">Help</a></li>
<li class="nav-li"> <a class= "nav-li-a" href= "#">Login</a></li>
</ul>
</nav>
</header>
<main>
<section class="ma-img">
<p class="p1"> Introducing Karma</p>
<p class="p2">bring wifi with you, everywhere you go</p>
<button class="learn-more">Learn More</button>
</section>
<section class="second-part">
<p class="part2">Everyone needs a little karma</p>
</section>
<article class="icon">
<div class="second-part"><img calss="icon-img" src="/img/icon-devices.svg" al="icon-devices">
<p class="p-icon"> Internet for all devices</p>
</div>
<div class="second-part"><img class="icon-img" src="/img/icon-coffee.svg" alt="icon-coffee">
<p class="p-icon">Boost your productivity</p>
</div>
<div class="second-part"><img class="icon-img" src="/img/icon-refill.svg" al="icon-refill">
<p class="p-icon">Pay as you go</p>
</div>
</article>
</main>
<hr class="line"></hr>
<footer class="footer">
<p class="footer-p"> Join us on </p>
<section class="icons-footer">
<img class="icon-footer1" src="./img/twitter-icon.svg" al="twitter icon">
</div>
<img class="icon-footer1" src="./img/facebook-icon.svg" alt="facebook icon">
</div>
<img class="icon-footer1" src="./img/instagram-icon.svg" alt="Instagram icon">
</div>
<p class="copyrights"> © Karma Mobility, Inc.</p>
</section>
</footer>
</body>
</html>

</html>