-
-
Notifications
You must be signed in to change notification settings - Fork 622
Nw6-Ayman-Matoo/HTML-CSS-Project week2 #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ayman-matoo
wants to merge
2
commits into
CodeYourFuture:master
Choose a base branch
from
Ayman-matoo:Module/update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,81 @@ | ||
|
||
/* We are using the 'Roboto' font from Google. This has already been added to your HTML header */ | ||
/* We are using the 'Roboto' font from Google. This has already been added to your HTML header */ | ||
* { | ||
margin: 0px; | ||
padding: 0px; | ||
text-align: center; | ||
color: white; | ||
} | ||
.header { | ||
position: relative; | ||
} | ||
|
||
body { | ||
font-family: 'Roboto', sans-serif; | ||
-webkit-font-smoothing: antialiased; | ||
font-family: "Roboto", sans-serif; | ||
-webkit-font-smoothing: antialiased; | ||
} | ||
h1 { | ||
font-size: 3rem; | ||
color: white; | ||
text-align: center; | ||
} | ||
.ul link { | ||
display: flex; | ||
align-items: center; | ||
justify-content: space-around; | ||
} | ||
nav ul li { | ||
display: inline-block; | ||
list-style: none; | ||
margin: 10px; | ||
} | ||
nav ul li a { | ||
text-decoration: none; | ||
color: gray; | ||
font-size: ; | ||
} | ||
nav ul li a:hover { | ||
color: red; | ||
} | ||
.top3 { | ||
float: right; | ||
font-size: 30px; | ||
width: 30px; | ||
} | ||
|
||
.image1 { | ||
background-image: url(/img/first-background.jpg); | ||
padding: 10em; | ||
} | ||
.button { | ||
background-color: orange; | ||
} | ||
.h1{color: black;} | ||
|
||
*/ Icons/ | ||
|
||
.icon{ | ||
height: 100px; | ||
} | ||
|
||
/** | ||
* Add your custom styles below | ||
* | ||
* Remember: | ||
* - Be organised, use comments and separate your styles into meaningful chunks | ||
* for example: General styles, Navigation styles, Hero styles, Footer etc. | ||
* | ||
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex' | ||
*/ | ||
.container{ | ||
display: flex; | ||
flex-direction: row; | ||
justify-content: space-evenly; | ||
} | ||
|
||
#p1{ | ||
color: black; | ||
} | ||
|
||
|
||
.test{ | ||
color:black; | ||
padding: 10px; | ||
} | ||
.icon2{ | ||
height: 40px;px; | ||
width: 40px; | ||
} | ||
#topimage{ | ||
float: left; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,72 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> | ||
<head> | ||
<meta charset="UTF-8" /> | ||
<meta | ||
name="viewport" | ||
content="width=device-width, initial-scale=1, shrink-to-fit=no" | ||
/> | ||
<title>Karma</title> | ||
<link href='https://fonts.googleapis.com/css?family=Roboto:400,500,300' rel='stylesheet' type='text/css'> | ||
<link rel="stylesheet" href="css/normalize.css"> | ||
<link rel="stylesheet" href="css/style.css"> | ||
<link rel="shortcut icon" type="image/x-icon" href="favicon.ico"> | ||
</head> | ||
<body> | ||
<link | ||
href="https://fonts.googleapis.com/css?family=Roboto:400,500,300" | ||
rel="stylesheet" | ||
type="text/css" | ||
/> | ||
<link rel="stylesheet" href="css/normalize.css" /> | ||
<link rel="stylesheet" href="css/style.css" /> | ||
<link rel="shortcut icon" type="image/x-icon" href="favicon.ico" /> | ||
</head> | ||
<body> | ||
<div class="header"> | ||
<span class="top3"> ≡</span> | ||
<nav> | ||
<img id="topimage" src="favicon.ico" alt="logo" /> | ||
<ul class="link"> | ||
<li><a href="">Meet karma</a></li> | ||
<li><a href="">How work</a></li> | ||
<li><a href="">Store</a></li> | ||
<li><a href="">help</a></li> | ||
<li><a href="">Blog</a></li> | ||
<li><a href="">Login</a></li> | ||
</ul> | ||
</nav> | ||
</div> | ||
<section class="image1"> | ||
<h1>Inroducing karma</h1> | ||
<p>Bring wifi with you everywhere, you go</p> | ||
<button class="button">learn more</button> | ||
</section> | ||
|
||
<!-- Add your HTML markup here --> | ||
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
<!-- All the images you need are in the 'img' folder --> | ||
<div> | ||
<h1 class="h1">Everything needs a little Karma.</h1> | ||
</div> | ||
<div class="container"> | ||
<div class="computer-icon"> | ||
<img class="icon" src="/img/icon-devices.svg" /> | ||
<p id="p1">internet all icon-devices</p> | ||
</div> | ||
<div class="coffe icon"> | ||
<img class="icon" src="/img/icon-coffee.svg" /> | ||
<p id="p1">Boot your productive</p> | ||
</div> | ||
<div class="payus"> | ||
<img class="icon" src="/img/icon-refill.svg" /> | ||
<p id="p1"> Pay US You go </p3> | ||
</div> | ||
</div> | ||
|
||
</body> | ||
<footer> | ||
|
||
<p class ="test">Join Us</p> | ||
<img class="icon" src="/img/twitter-icon.svg"> | ||
|
||
|
||
<img class= "icon2" src="/img/instagram-icon.svg"> | ||
|
||
|
||
<img src="/img/facebook-icon.svg"> | ||
<p>Karma Mobile.int</p> | ||
|
||
</footer> | ||
Comment on lines
+58
to
+70
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The footer icons are in circular border and not as big as you have them in your PR, kindly work around it and do reach out if you are finding it difficult. |
||
</body> | ||
</html> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to style this button to look like the one on the assignment, such as working on giving it some padding, and the letter case etc.