NW6|Bakhat Begum|Module-JS1 |Bakha/week-3| Sprint-3|Week-3 #162
Conversation
BakhatBegum
changed the title
BakhatBegum
changed the title
There was a problem hiding this comment.
Very good job!!
Since you have already identified angle === 90 as a right angle in line 29, there's no need to restate angle != 90 in line 29. The first condition (angle === 90) has been satisfied, and the code does not proceed to the second line.
There was a problem hiding this comment.
In my view, users will input not only numbers but also cards with unique suits, such as 'J♥'. In this scenario, your code should be designed to convert these inputs into their corresponding numerical values.
There was a problem hiding this comment.
Good job! Additionally, ensure that 'a', 'b', and 'c' cannot be zero in your code. Since it can not be a triangle if either of the sides is 0.
| function getAngleType(angle){ | ||
| if (angle === 90){ | ||
| return "Right angle"; | ||
| } else if (angle != 90 && angle < 90){ |
There was a problem hiding this comment.
this can easily be refactored into angle < 90`. you didnt take care of negative numbers, 360 and numbers greater than 360
| function isProperFraction(numerator, denominator) { | ||
| if (numerator < denominator){ | ||
| return true; | ||
| }else if (denominator === 0) { |
| //ans : Store this expression in a variable revised code considers both the hours and minutes in the input time, correctly determines whether it's morning or afternoon. | ||
|
|
||
|
|
||
| function formatAs12HourClock(time) { |
Learners, PR Template
Self checklist
Changelist
Some parts were complicated. Blackjack cards took new horses to understand and write the code. Over all day by day, I am getting better.
Questions
I would be very happy to get feedback.