Skip to content

Conversation

Grajales-K
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

In this project, I learned how to use string methods by referring to the MDN documentation, how to set and manage variables, and how data flows within functions. I also learned how to invoke functions properly, debug issues to understand why something doesn't work, perform operations on strings, and iterate through strings based on their length.

Questions

Ask any questions you have for your reviewer.

@Grajales-K Grajales-K added 🔑 Priority Key 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 23, 2024
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Dec 23, 2024
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good.
Some of the explanations given in the debug and errors folders are not quite correct.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Dec 23, 2024
@Grajales-K Grajales-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 23, 2024
@cjyuan
Copy link
Contributor

cjyuan commented Dec 23, 2024

Changed code is good. I left you additional comments in the resolved conversations.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 23, 2024
@Grajales-K Grajales-K added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Dec 26, 2024
Copy link

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Wrong number of parts separated by |s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants