LONDON | ITP-MAY-25 | SURAFEL WORKNEH | Module-Structuring-and-Testing-Data | Coursework/sprint 1 #646

SuWebOnes · 2025-07-07T20:20:15Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide-
My changes meet the requirements of this task

Changelist

Briefly explain my PR.

Function Parameter and Return Handling
String Manipulation and Formatting
Time Conversion Logic
Testing and Debugging

Questions

Ask any questions you have for your reviewer.

…gnment sprint -1 of 1-count.js

…als.js

…m number generation in sprint -1 of 4-random.js

…nt -1 of 0.js

…'let' in sprint -1 of 1.js

…t -1 of 2.js

…licing in sprint -1 of 3.js

…ons in sprint -1 of 4.js

…reassignment in percentage change calculation

…sprint -1 of 2-time-format.js

and describe the purpose in sprint -1 of 3-to-pounds.js

… sprint -1 of chrome.md

…1 of objects.md

cjyuan

The checkboxes in the PR descriptions are not in proper markdown syntax. Can you fix their markdown syntax? (I fixed one of them for you so that you can follow the example).

Sprint-1/1-key-exercises/3-paths.js

Sprint-1/2-mandatory-errors/4.js

Sprint-1/3-mandatory-interpret/1-percentage-change.js

cjyuan · 2025-07-17T17:41:08Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+// 1. const penceString = "399p": initialize a string variable with the value "399p"
+//2. Removes the trailing "p" from the string: and result will be 399
+//3. Ensures the number has at least 3 digits by padding from the left with zeros: like 000
+//4. Extracts the pound portion: "3"


Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") (line 16) from the code?
In other words, do we really need .padEnd(2, "0") in this script?

yes, it can work without '.padEnd(2, "0") (line 16) from the code? ' and I tested with different digits and it works

You don't have to delete .padEnd(2, "0"). It's a "code reading" practice.
More importantly, do you know why the script can still works correctly without .padEnd(2, "0")?

Do you know why the script can still works correctly without .padEnd(2, "0")?

Sprint-1/4-stretch-explore/chrome.md

SuWebOnes · 2025-07-21T13:29:39Z

CJ would you mind if you check revisions please?

cjyuan · 2025-07-21T13:56:32Z

Sprint-1/4-stretch-explore/chrome.md

 What is the return value of `prompt`?
+Shows input dialog


What is the value returned by prompt()?
The function returns different values depending on whether the user clicks the OK button or the Cancel button.

cjyuan · 2025-07-21T13:57:53Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+// 1. const penceString = "399p": initialize a string variable with the value "399p"
+//2. Removes the trailing "p" from the string: and result will be 399
+//3. Ensures the number has at least 3 digits by padding from the left with zeros: like 000
+//4. Extracts the pound portion: "3"


Do you know why the script can still works correctly without .padEnd(2, "0")?

SuWebOnes · 2025-07-21T22:21:21Z

Do you know why the script can still works correctly without .padEnd(2, "0")?
My Answer: padStart(3, "0") ensures that the conversion from pence to pounds so it worked even without .padEnd(2, "0")

cjyuan · 2025-07-21T22:58:40Z

Your answer to this question What is the return value of prompt? is not correct, but since it is an optional stretch exercise, I will mark this PR as complete first.

Also, it is helpful to change the label whenever your responses/changes are ready to be reviewed.

github-actions · 2025-08-14T10:26:12Z

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Structuring and testing data) doesn't match expected format (example: 'Sprint 2', without quotes)

github-actions · 2025-08-14T20:37:26Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-08-14T20:40:50Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Structuring and testing data) doesn't match expected format (example: 'Sprint 2', without quotes)

github-actions · 2025-08-14T21:03:05Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions · 2025-08-14T21:05:25Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions · 2025-08-14T21:11:37Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module-Structuring-and-Testing-Data) doesn't match expected format (example: 'Sprint 2', without quotes)

SuWebOnes added 14 commits June 24, 2025 19:07

update: Add console log and comments to clarify count variable reassi…

12eb682

…gnment sprint -1 of 1-count.js

update: comments for clarity on initials variable creation in 2-initi…

b57e0f3

…als.js

update: Implement dir and ext variable assignments in 3-paths.js

a7ffaa8

update: breaking down the expression and explain for clarity on rando…

de6389d

…m number generation in sprint -1 of 4-random.js

update: Convert instructions to comments to prevent execution in spri…

3425e3b

…nt -1 of 0.js

update: Clarify age variable reassignment and correct declaration to …

fa0ebc7

…'let' in sprint -1 of 1.js

update: Fix variable declaration order and error explanation in sprin…

6697426

…t -1 of 2.js

update: Add prediction and explanation for TypeError in card number s…

61fd838

…licing in sprint -1 of 3.js

update: Add detailed comments and examples for time conversion functi…

4a786db

…ons in sprint -1 of 4.js

update: Fix minor formatting issues in comments and clarify variable …

7a0b1f7

…reassignment in percentage change calculation

update: explain and comments for clarity in time format calculations …

6992670

…sprint -1 of 2-time-format.js

update: step-by-step breakdown of each line in this program

ed5a315

and describe the purpose in sprint -1 of 3-to-pounds.js

update: explanations for alert and prompt functions in Chrome console…

7b076d8

… sprint -1 of chrome.md

update: explanations for console methods and dot notation in sprint -…

2f5a89b

…1 of objects.md

SuWebOnes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 7, 2025

SuWebOnes changed the title ~~Coursework/sprint 1~~ London | May-2025 | Surafel Workneh | Coursework/sprint 1 Jul 7, 2025

Update 3-paths.js

2fc4c90

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 17, 2025

cjyuan reviewed Jul 17, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 17, 2025

SuWebOnes added 5 commits July 18, 2025 21:45

update: remove unimportant code lines

e6ec04b

update: testing with different digits and removing unwanted code lines

79cc401

update: correcting for generalized output input case

61bac86

update: correcting padding for hours time

5f92f70

update return value of prompt

b6d548d

SuWebOnes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 21, 2025

cjyuan reviewed Jul 21, 2025

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 21, 2025

SuWebOnes added 🏕 Priority Mandatory This work is expected 🔑 Priority Key labels Jul 21, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 21, 2025

This was referenced Jul 22, 2025

ITP-MAY-2025 | Structuring and testing data | SURAFEL_WORKNEH #680

Closed

ITP-MAY-2025 | Structuring and testing data | SURAFEL_WORKNEH SuWebOnes/My-Coursework-Planner#47

Open

illicitonion removed the 🔑 Priority Key label Aug 14, 2025

Merge branch 'main' into coursework/sprint-1

2120ef5

illicitonion closed this Sep 1, 2025

Uh oh!

LONDON | ITP-MAY-25 | SURAFEL WORKNEH | Module-Structuring-and-Testing-Data | Coursework/sprint 1 #646

LONDON | ITP-MAY-25 | SURAFEL WORKNEH | Module-Structuring-and-Testing-Data | Coursework/sprint 1 #646

Uh oh!

Conversation

SuWebOnes commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

SuWebOnes Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 19, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SuWebOnes commented Jul 21, 2025

Uh oh!

cjyuan Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

SuWebOnes commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjyuan commented Jul 21, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

Uh oh!

SuWebOnes commented Jul 7, 2025 •

edited

Loading

SuWebOnes commented Jul 21, 2025 •

edited

Loading