West Midlands | SDC-July | Gabriel Deng | Sprint 4 | Implement shell tools in python #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tools in python Having people write `s/s/S/` is a little more confusing than `s/i/I/` for their first exercise. <!-- You must title your PR like this: COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK For example, NW4 | Carol Owen | HTML-CSS-Module | Week1 Complete the task list below this message. If your PR is rejected, check the task list. --> ## Learners, PR Template Self checklist - [ ] I have committed my files one by one, on purpose, and for a reason - [ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK - [ ] I have tested my changes - [ ] My changes follow the [style guide](https://curriculum.codeyourfuture.io/guides/contributing/) - [ ] My changes meet the [requirements](./README.md) of this task ## Changelist Briefly explain your PR. ## Questions Ask any questions you have for your reviewer.
gai93003
added
Needs Review
LonMcGregor
added
the
Review in progress
|
Hi, I can't review your code yet. If you look at the "files changed" tab on this PR you will see the problem as there are hundreds of files that don't need to be there. It looks like you're using a virtual environment, which is a good idea if you are using multiple libraries, but needs to be handled carefully within a VCS. Could you look up how to properly handle python virtual environments within git so this problem doesn't happen? |
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having people write
s/s/S/is a little more confusing thans/i/I/for their first exercise.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.