Skip to content

London | SDC-July-2025 | Ali Qassab | Sprint 4 | Implement-cowsay/solution #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

London | SDC-July-2025 | Ali Qassab | Sprint 4 | Implement-cowsay/solution #155

wants to merge 2 commits into from

Conversation

AliQassab
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

@AliQassab AliQassab added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2025
@DaryaShirokova DaryaShirokova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-4) doesn't match expected format (example: 'Sprint 2', without quotes)

1 similar comment
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-4) doesn't match expected format (example: 'Sprint 2', without quotes)

@DaryaShirokova
Copy link

Please make sure to fix the validation error: Validation error: Bad title: Sprint part (Sprint-4) doesn't match expected format (example: 'Sprint 2', without quotes)

DaryaShirokova
DaryaShirokova approved these changes Aug 17, 2025
View reviewed changes
implement-cowsay/cow.py
@@ -0,0 +1,13 @@

import argparse
import cowsay
Copy link

@DaryaShirokova DaryaShirokova Aug 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is external dependency, it should be declared somewhere (could be requirements.txt file).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added requirements.txt for cowsay.

@DaryaShirokova DaryaShirokova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 17, 2025
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-4) doesn't match expected format (example: 'Sprint 2', without quotes)

1 similar comment
@github-actions GitHub Actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-4) doesn't match expected format (example: 'Sprint 2', without quotes)

@AliQassab AliQassab changed the title London | SDC-July-2025 | Ali Qassab | Sprint-4 | Implement-cowsay/solution London | SDC-July-2025 | Ali Qassab | Sprint 4 | Implement-cowsay/solution Aug 18, 2025
@DaryaShirokova DaryaShirokova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DaryaShirokova DaryaShirokova DaryaShirokova approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 4 Assigned during Sprint 4 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliQassab @DaryaShirokova