London | 25-SDC-July | Eyuel Abraham | Sprint 4 | Implementing cowsay #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyuell21
added
the
Needs Review
DaryaShirokova
added
Review in progress
|
|
||
| # Dynamically call the animal function (like cowsay.turtle("hello")) | ||
| try: | ||
| animal_func = getattr(cowsay, args.animal) |
There was a problem hiding this comment.
You can check out an alternative get_output_string method here to avoid getattr (not the best choice to use if there is alternative - it make code more readable).
| try: | ||
| animal_func = getattr(cowsay, args.animal) | ||
| output = animal_func(message) | ||
| print(output) |
There was a problem hiding this comment.
You program always prints none in the end, please debug why this is and fix (should be a simple fix :) )
DaryaShirokova
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Python implementation of Cowsay.
Questions
Ask any questions you have for your reviewer.