Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware #68

Merged
merged 12 commits into from
Aug 5, 2024
Merged

Middleware #68

merged 12 commits into from
Aug 5, 2024

Conversation

lovromazgon
Copy link
Member

Description

Introduces processor middleware and implements two middlewares:

Fixes ConduitIO/conduit#1707.

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon marked this pull request as ready for review August 2, 2024 13:55
@lovromazgon lovromazgon requested a review from a team as a code owner August 2, 2024 13:55
middleware.go Outdated Show resolved Hide resolved
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like having the flexibility of separate middlewares so this could be easily extended by users (when the needs comes). Only left some nits. Great work @lovromazgon

util.go Show resolved Hide resolved
middleware.go Show resolved Hide resolved
middleware.go Show resolved Hide resolved
middleware.go Show resolved Hide resolved
middleware.go Show resolved Hide resolved
middleware.go Show resolved Hide resolved
schema/cached.go Show resolved Hide resolved
middleware.go Show resolved Hide resolved
middleware.go Outdated Show resolved Hide resolved
middleware.go Outdated Show resolved Hide resolved
middleware.go Outdated Show resolved Hide resolved
middleware.go Outdated Show resolved Hide resolved
middleware.go Show resolved Hide resolved
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIC, cleared for takeoff.:)

@lovromazgon lovromazgon merged commit 9b6b1e8 into main Aug 5, 2024
5 checks passed
@lovromazgon lovromazgon deleted the lovro/middleware branch August 5, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Schemas] Decode raw data in records with schemas before passing them to processors
4 participants