11.22 #101
Open
11.22 #101
+3,177
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlt-cortex
requested changes
Nov 28, 2022
| test_op("upsampling"); // formal & cpu pass | ||
| test_op("dense"); // formal & cpu pass | ||
| int main(int argc, char* argv[]) { | ||
| ctx = APIDevTypeMap.at(stoi(argv[1])); |
There was a problem hiding this comment.
Add more information about arguments, such as the meaning, format, etc.
tests/test_op.cc
Outdated
Comment on lines
688
to
694
| //test_op("non_max_suppression"); // formal & cpu pass | ||
| // test_op("broadcast_sub"); // formal & cpu pass | ||
| // test_op("broadcast_add"); // formal & cpu pass | ||
| // test_op("broadcast_mul"); // formal & cpu pass | ||
| // test_op("broadcast_max"); // formal & cpu pass | ||
| // test_op("broadcast_div"); // formal & cpu pass | ||
| // test_op("broadcast_greater"); // formal & cpu pass |
There was a problem hiding this comment.
Update the GPU pass information like your test documentation.
wlt-cortex
requested changes
Dec 27, 2022
tests/test_op2.cc
Outdated
| return result(tshape, tdata, params, attr)[0]; | ||
| } | ||
|
|
||
| NDArray dense(NDArray const& data, NDArray const& weight, string attr_str, NDArray* bias = nullptr) |
There was a problem hiding this comment.
Support three typed-APIs:
- NDArray
- DLTensor
- int32_t *
tests/test_op2.cc
Outdated
| return res; | ||
| } | ||
|
|
||
| NDArray conv2d(NDArray const& data, NDArray const& weight, string attr_str, NDArray* bias = nullptr) |
There was a problem hiding this comment.
use typed-attributes in parameters, instead of attr_str.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.