Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform fixes for falconjs #444

Closed
wants to merge 1 commit into from

Conversation

evanstoner
Copy link

Three types of fixes:

  1. Parameters of type array that define an enum at the parameter root, versus on the items of the parameter, are incorrect since the root enum would define possible array values. We want to define possible values for strings in the array. Move those enums under items. NOTE: the parameter index is hardcoded...I see this done one other place in the file already but it makes me nervous. There is probably a smarter way to search for an array element with a value?
  2. SavedSearchExecuteRequestV1 defined Parameters object with string values and another parameters object with no defined value. Prefer the uppercase one since it's more specific.
  3. AccessTokenResponseV1 doesn't define any required fields, so in typescript the accessToken is string | undefined. This makes it incompatible with strings. Seems like if we have a token response, it's definitely going to have a token in it.

@evanstoner
Copy link
Author

Adding these directly to falconjs. CrowdStrike/falconjs#211

@evanstoner evanstoner closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant