feat: 지도 페이지 마크업 (작업 중) #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmswl98
approved these changes
Aug 21, 2023
Comment on lines
+35
to
+36
| const [latitude, setLatitude] = useState(33.450701); //현재 위치 (위도) | ||
| const [longitude, setLongitude] = useState(126.570667); //현재 위치 (경도) |
There was a problem hiding this comment.
useEffect 내부에서도 위도와 경도 값이 사용되고 있어서 상수화하면 좋을 것 같네용
Comment on lines
+30
to
+35
| const Button = styled.div` | ||
| width: 40px; | ||
| height: 40px; | ||
| padding: 10px; | ||
| color: ${palette.white}; | ||
| `; |
There was a problem hiding this comment.
ask; 네이밍은 버튼인데 div 태그인 이유가 있을까요오??
| import ShopIcon from '@assets/svg/shopIcon.svg'; | ||
| import { PLACE_TYPE } from '@constants/map'; | ||
|
|
||
| const IconMapType = (placeType: string) => { |
There was a problem hiding this comment.
placeType값이 MAP_BUTTON_TYPE 상수의 키 값만 들어오는 것 같은데 아래처럼 타입을 좁혀볼 수 있을 것 같아요!!
Suggested change
| const IconMapType = (placeType: string) => { | |
| const IconMapType = (placeType: keyof typeof MAP_BUTTON_TYPE) => { |
There was a problem hiding this comment.
감사합니다!!! 리뷰 달아주신 부분들 emotion 적용 후에 수정해볼게요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈 번호
#6
✨ 작업 내용
📝 작업 상세 내용
🎨 구현 스크린샷
💎 TODO