Make LinkButton Component Responsive #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sounmind
force-pushed
the
50-make-link-button-responsive
branch
2 times, most recently
from
7690543 to
af34646
Compare
sounmind
changed the base branch from
main
to
56-bug-fix-passing-wrong-attributes-to-linkbutton-component-in-header-component
sounmind
force-pushed
the
50-make-link-button-responsive
branch
from
af34646 to
d2dde32
Compare
sounmind
commented
Jun 16, 2024
sounmind
commented
Jun 16, 2024
Base automatically changed from
56-bug-fix-passing-wrong-attributes-to-linkbutton-component-in-header-component
to
main
June 16, 2024 22:53
DaleSeo
reviewed
Jun 20, 2024
DaleSeo
reviewed
Jun 20, 2024
sounmind
force-pushed
the
50-make-link-button-responsive
branch
from
d2dde32 to
4a58b5c
Compare
sounmind
force-pushed
the
50-make-link-button-responsive
branch
from
2b87fb9 to
9aa8f1f
Compare
sounmind
commented
Jun 22, 2024
Comment on lines
+53
to
+54
| <ds-button-link href="#join-instruction-container" size="small" variant="ghost">참여방법 안내</ds-button-link> | ||
| <ds-button-link href="https://discord.gg/43UkheRV" size="small" variant="secondary">디스코드 참여하기</ds-button-link> |
There was a problem hiding this comment.
@SamTheKorean header 컴포넌트 내부에서 button link 컴포넌트를 사용하고 있습니다. 그런데 button link의 사용법에 변경이 발생하면(지금처럼 이름이 변경되거나 전달해야 하는 attribute가 달라졌을 경우), HTML 파일에서뿐만 아니라 header 안에서도 변경을 해야 합니다. 이런 컴포넌트 사용이 많아질수록 하나를 변경했을 때, 같이 변경해야 하는 지점이 많아집니다. 이는 미래에 유지보수가 힘들어질 수 있는 신호이기도 합니다. 이것은 정말 문제가 맞을지? 맞다면 어떻게 해결할 수 있을지? 천천히 생각해보아요!
cc. @DaleStudy/website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging