Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modify review item component #54

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Conversation

yolophg
Copy link
Contributor

@yolophg yolophg commented Jun 15, 2024

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

@yolophg yolophg requested a review from a team as a code owner June 15, 2024 21:25
@yolophg yolophg marked this pull request as draft June 15, 2024 21:25
@yolophg yolophg linked an issue Jun 15, 2024 that may be closed by this pull request
@yolophg yolophg marked this pull request as ready for review June 15, 2024 21:31
@yolophg yolophg marked this pull request as draft June 15, 2024 21:32
@yolophg yolophg force-pushed the helena/review-item-component branch from d52c3ed to 7468f4d Compare June 15, 2024 21:55
@yolophg yolophg marked this pull request as ready for review June 15, 2024 21:58
@yolophg yolophg marked this pull request as draft June 15, 2024 22:02
@yolophg yolophg marked this pull request as ready for review June 15, 2024 22:15
Comment on lines +79 to +81
<footer class="review-footer">
<figcaption>${this.name}</figcaption>
</footer>
Copy link
Member

@sounmind sounmind Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 페이지 안에 footer가 두 개 이상 있으면 안 될 것 같아요. 어색해보이네요.
하지만 또, 찾아보면 꼭 footer가 하나만 있어야 한다는 것도 아니네요. SEO에도 큰 영향은 없어보입니다.

@DaleSeo @nhistory 분들은 어떻게 생각하시나요?

@yolophg yolophg merged commit 2305bf2 into main Jun 26, 2024
@yolophg yolophg deleted the helena/review-item-component branch June 26, 2024 16:39
@yolophg yolophg restored the helena/review-item-component branch June 26, 2024 17:38
@yolophg yolophg deleted the helena/review-item-component branch June 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Review Item Component
2 participants