[CONTINT-4635] Resolve Docker Image Layer Digest Bug #35543
Conversation
github-actions
bot
added
short review
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: dda inv aws.create-vm --pipeline-id=60965819 --os-family=ubuntuNote: This applies to commit dc6f09d |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: aebece8 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +3.97 | [+3.12, +4.81] | 1 | Logs |
| ➖ | otlp_ingest_traces | memory utilization | +0.73 | [+0.35, +1.11] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.56 | [-2.26, +3.38] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.26 | [+0.14, +0.39] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.13 | [-0.63, +0.88] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.11 | [-0.35, +0.58] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.11 | [-0.03, +0.26] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.11 | [+0.05, +0.16] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.70, +0.72] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.00 | [-0.80, +0.80] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.00 | [-0.63, +0.63] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.00 | [-0.79, +0.79] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.02] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.29, +0.28] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.02 | [-0.86, +0.82] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.04 | [-0.82, +0.75] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.55 | [-0.59, -0.51] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.69 | [-0.77, -0.62] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -1.17 | [-1.33, -1.01] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -1.22 | [-1.33, -1.11] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
justin-lesko
changed the title
justin-lesko
added
the
qa/done
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
There was an unexpected error while creating the working branch: cannot create branch DataDog/datadog-agent/merge_request:{repository:{owner:"DataDog" name:"datadog-agent"} queued_at:{seconds:1743699115 nanos:927597000} status_with_reason:STATUS_WITH_REASON_QUEUED priority:200 created_at:{seconds:1743699115 nanos:927992000} pull_request_number:35543 base_branch:"main" head_sha:"dc6f09d291cf76eec0249a0b586ff66157ea0890" id:"c76d63fa-6bdc-43f6-8a83-7590015a8bef" status:STATUS_QUEUED triggered_by:"justin.lesko@datadoghq.com" merge_status_workflow_id:"886d1473-138e-47e1-ad94-3197009d669e_41"} name:"mq-working-branch-main-b994c20" temporal_execution_workflow_id:"863a74ff-e8c5-418a-9ff9-756b0239cabe_183" temporal_execution_run_id:"5d54d243-995f-4470-89cd-93b161f34d54" This could indicate that something doesn't work properly with the build system or that this one has reached its maximum capacity. DetailsError: cannot create branch DataDog/datadog-agent/merge_request:{repository:{owner:"DataDog" name:"datadog-agent"} queued_at:{seconds:1743699115 nanos:927597000} status_with_reason:STATUS_WITH_REASON_QUEUED priority:200 created_at:{seconds:1743699115 nanos:927992000} pull_request_number:35543 base_branch:"main" head_sha:"dc6f09d291cf76eec0249a0b586ff66157ea0890" id:"c76d63fa-6bdc-43f6-8a83-7590015a8bef" status:STATUS_QUEUED triggered_by:"justin.lesko@datadoghq.com" merge_status_workflow_id:"886d1473-138e-47e1-ad94-3197009d669e_41"} name:"mq-working-branch-main-b994c20" temporal_execution_workflow_id:"863a74ff-e8c5-418a-9ff9-756b0239cabe_183" temporal_execution_run_id:"5d54d243-995f-4470-89cd-93b161f34d54" FullStacktrace: |
justin-lesko
changed the title
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
mergequeue build completed successfully, but the github api returned an error while merging the pr. DetailsError: PUT https://api.github.com/repos/DataDog/datadog-agent/pulls/35543/merge: 405 Merge already in progress [] FullStacktrace: |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Background
We previously identified a pattern between the outputs of the
docker historyanddocker inspectcommands. Layers fromdocker historywithoutSizeorCreated Bymatched with the layer digests fromdocker inspect. More details can be found in the original PR description #33384.Changes Introduced
This PR prevents the agent from panicking when attempting to match
docker inspectdigests todocker historylayers; if there is a mismatch in layers detected, the code falls back to its previous behavior.Motivation
Resolve a bug report.
Describe how you validated your changes
Wrote a unit test to replicate the behavior described in the bug report.
Possible Drawbacks / Trade-offs
Additional Notes
We reached out to the customer for more details on the specific image that caused this panic. For now, I am unable to reproduce and test with anything other than unit tests.