Skip to content

Conversation

Yumasi
Copy link
Member

@Yumasi Yumasi commented Sep 16, 2025

What does this PR do?

This PR makes the collection interval of Service Discovery configurable via the discovery.service_collection_interval configuration option.

Motivation

DSCVR-142

Describe how you validated your changes

Setting the new discovery.service_collection_interval to a very short period (e.g 10s) and, without starting system-probe (so that the collection fails), witness in logs that it does try to collect services at the configured interval.

Additional Notes

@Yumasi Yumasi added qa/no-code-change No code change in Agent code requiring validation team/agent-discovery changelog/no-changelog labels Sep 16, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Sep 16, 2025
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 086be271-27fb-4844-aad9-d645da817c56

Baseline: 2f992b5
Comparison: 8fa638e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +8.44 [+5.16, +11.73] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +8.44 [+5.16, +11.73] 1 Logs
ddot_metrics_sum_delta memory utilization +0.23 [+0.08, +0.39] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.20 [+0.00, +0.39] 1 Logs
ddot_logs memory utilization +0.14 [+0.09, +0.19] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.13 [+0.08, +0.19] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.10 [-0.50, +0.70] 1 Logs
ddot_metrics memory utilization +0.06 [-0.10, +0.22] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.59, +0.67] 1 Logs
otlp_ingest_metrics memory utilization +0.04 [-0.09, +0.16] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.62, +0.66] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.23, +0.25] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.62, +0.57] 1 Logs
file_tree memory utilization -0.09 [-0.13, -0.05] 1 Logs
otlp_ingest_logs memory utilization -0.13 [-0.25, -0.02] 1 Logs
quality_gate_idle_all_features memory utilization -0.14 [-0.17, -0.10] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.26 [-0.30, -0.23] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.43 [-0.64, -0.22] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization -0.85 [-1.02, -0.69] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.99 [-1.06, -0.92] 1 Logs
quality_gate_logs % cpu utilization -3.17 [-5.89, -0.44] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -3.30 [-3.43, -3.17] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7f6d07c

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0.72}$$ $${701.65}$$ < $${703.13}$$ $${+0.23}$$ $${177.16}$$ < $${178.38}$$
agent_deb_amd64_fips $${+0.72}$$ $${696.12}$$ < $${697.61}$$ $${+0.08}$$ $${176.15}$$ < $${177.15}$$
agent_heroku_amd64 $${+0.72}$$ $${340.91}$$ < $${341.62}$$ $${+0.13}$$ $${90.54}$$ < $${91.52}$$
agent_msi $${+2.53}$$ $${988.23}$$ < $${990.42}$$ $${+0.29}$$ $${151.43}$$ < $${152.42}$$
agent_rpm_amd64 $${+0.72}$$ $${701.63}$$ < $${703.12}$$ $${+0.12}$$ $${179.34}$$ < $${180.53}$$
agent_rpm_amd64_fips $${+0.72}$$ $${696.11}$$ < $${697.6}$$ $${+0.18}$$ $${177.79}$$ < $${178.87}$$
agent_rpm_arm64 $${+0.64}$$ $${688.33}$$ < $${689.82}$$ $${+0.14}$$ $${161.04}$$ < $${162.16}$$
agent_rpm_arm64_fips $${+0.63}$$ $${683.59}$$ < $${685.08}$$ $${+0.03}$$ $${159.87}$$ < $${161.11}$$
agent_suse_amd64 $${+0.72}$$ $${701.63}$$ < $${703.12}$$ $${+0.12}$$ $${179.34}$$ < $${180.53}$$
agent_suse_amd64_fips $${+0.72}$$ $${696.11}$$ < $${697.6}$$ $${+0.18}$$ $${177.79}$$ < $${178.87}$$
agent_suse_arm64 $${+0.64}$$ $${688.33}$$ < $${689.82}$$ $${+0.14}$$ $${161.04}$$ < $${162.16}$$
agent_suse_arm64_fips $${+0.63}$$ $${683.59}$$ < $${685.08}$$ $${+0.03}$$ $${159.87}$$ < $${161.11}$$
docker_agent_amd64 $${+0.72}$$ $${773.02}$$ < $${774.54}$$ $${+0.2}$$ $${265.16}$$ < $${266.46}$$
docker_agent_arm64 $${+0.64}$$ $${783.65}$$ < $${785.2}$$ $${+0.17}$$ $${251.61}$$ < $${252.92}$$
docker_agent_jmx_amd64 $${+0.72}$$ $${963.88}$$ < $${965.41}$$ $${+0.2}$$ $${333.78}$$ < $${335.08}$$
docker_agent_jmx_arm64 $${+0.64}$$ $${963.12}$$ < $${964.66}$$ $${+0.17}$$ $${316.22}$$ < $${317.54}$$
docker_cluster_agent_amd64 $${-0}$$ $${213.09}$$ < $${213.74}$$ $${+0}$$ $${72.34}$$ < $${73.2}$$
docker_cluster_agent_arm64 $${-0.06}$$ $${228.97}$$ < $${229.68}$$ $${+0}$$ $${68.6}$$ < $${69.48}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.06}$$ < $${7.12}$$ $${0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.41}$$ < $${39.3}$$ $${+0}$$ $${14.84}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.05}$$ < $${37.94}$$ $${+0}$$ $${14.28}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.65}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.23}$$ < $${29.12}$$ $${-0}$$ $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.65}$$ < $${30.53}$$ $${+0}$$ $${7.83}$$ < $${8.77}$$
dogstatsd_suse_amd64 $${0}$$ $${29.65}$$ < $${30.53}$$ $${+0}$$ $${7.83}$$ < $${8.77}$$
iot_agent_deb_amd64 $${0}$$ $${54.38}$$ < $${54.97}$$ $${+0}$$ $${13.58}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.67}$$ < $${51.9}$$ $${+0}$$ $${11.72}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${51.23}$$ < $${51.84}$$ $${+0}$$ $${11.79}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.38}$$ < $${54.97}$$ $${+0}$$ $${13.6}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${54.38}$$ < $${54.97}$$ $${+0}$$ $${13.6}$$ < $${14.47}$$

@Yumasi Yumasi added qa/done QA done before merge and regressions are covered by tests and removed qa/no-code-change No code change in Agent code requiring validation labels Sep 17, 2025
@Yumasi Yumasi marked this pull request as ready for review September 17, 2025 13:41
@Yumasi Yumasi requested review from a team as code owners September 17, 2025 13:41
@Yumasi Yumasi requested a review from dustmop September 17, 2025 13:41
@Yumasi Yumasi added the ask-review Ask required teams to review this PR label Sep 17, 2025
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for agent-configuration owned files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-review Ask required teams to review this PR changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-discovery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants