Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Enable SQL Injection tests #4405

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

y9v
Copy link
Member

@y9v y9v commented Mar 27, 2025

Motivation

We need to test SQL Injection detection feature in the Ruby tracer starting from version 2.14.0.dev.

Changes

This PR enables SQL Injection tests for Ruby.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v self-assigned this Mar 27, 2025
@y9v y9v force-pushed the ruby-enable-sql-injection-tests branch 2 times, most recently from a360c2e to 0f6598d Compare March 27, 2025 17:13
@marcotc
Copy link
Member

marcotc commented Mar 27, 2025

Awesome work!

@y9v y9v force-pushed the ruby-enable-sql-injection-tests branch 4 times, most recently from 4560060 to 30afc1c Compare April 3, 2025 09:44
@y9v y9v force-pushed the ruby-enable-sql-injection-tests branch from 30afc1c to 57aa08d Compare April 4, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants