Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] I need to run the ci. #4481

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Apr 7, 2025

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@PROFeNoM PROFeNoM changed the title wip I need to run the ci. Apr 7, 2025
@PROFeNoM PROFeNoM force-pushed the munir/php-tests-composer-install branch 3 times, most recently from 2c28cde to b6d3b1a Compare April 7, 2025 09:10
@PROFeNoM PROFeNoM force-pushed the munir/php-tests-composer-install branch from b6d3b1a to f928f5a Compare April 7, 2025 09:21
@PROFeNoM PROFeNoM changed the title I need to run the ci. [php] I need to run the ci. Apr 7, 2025
@PROFeNoM PROFeNoM force-pushed the munir/php-tests-composer-install branch from f928f5a to 1150812 Compare April 7, 2025 09:30
@PROFeNoM PROFeNoM force-pushed the munir/php-tests-composer-install branch from 1150812 to 54b8c5e Compare April 7, 2025 09:51
@PROFeNoM PROFeNoM changed the base branch from munir/php-tests to main April 7, 2025 09:52
@PROFeNoM PROFeNoM force-pushed the munir/php-tests-composer-install branch 3 times, most recently from 8a7d232 to ed38c2d Compare April 7, 2025 12:03
@PROFeNoM PROFeNoM force-pushed the munir/php-tests-composer-install branch from ed38c2d to 51d2cc0 Compare April 7, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants