Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Spring-boot Increase Default Max Http Header Size #4483

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Apr 7, 2025

Motivation

Springboot defaults the max http header sizes of all combined headers to be 8192 bytes. Since we by default support a maximum size of 8192 bytes for baggage headers alone, we need to increase this limit in the weblog app to receive baggage headers in the tracer.

Changes

Update Springboot weblog app max-http-header-size.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd merged commit f2afea9 into main Apr 7, 2025
135 checks passed
@mhlidd mhlidd deleted the mhlidd/update_springboot_max_header branch April 7, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants