Document Public and Private Networks, alongwith Network Aliases #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit111
reviewed
Jan 6, 2025
| networks: | ||
| public: | ||
| aliases: | ||
| - app |
There was a problem hiding this comment.
Suggested change
| - app | |
| - app |
raphaeltm
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Something missing IMO in this: it's not clear if it defaults to private or public. I think we had previously talked about reducing default cost by not provisioning NAT gateways and keeping everything in public subnets by default, but I don't know if we implemented that. One way or another, I think we should be explicit about what the default is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/DefangLabs/defang-mvp/pull/1261
Docs to describe how to configure public or private networks, and network aliases.