Fix windows CI by removing virtual file system cache #3912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
changed the title
jkelleyrtp
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
The windows CI on this PR is about 19 minutes which is extremely long...
But none of our windows CI is working so I'll merge this now so we can get other CI working but I would really like to fix this properly at some point.
I experimented with self-hosted runners awhile back but it might be a bit simpler to just use the paid github ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just disables the vfs logic in windows CI. This will make the CI slower, but it does fix the caching issue. matrix_test (x86_64-apple-darwin, macos-13, 1.84.0, false, test, --all --tests) runs at a similar speed so the overall slowdown is only ~2m. The underlying issue might be related to rust-lang/rustup#2417 which could be fixed by clearing the rustup cache, but I can't find the cache for windows CI in
gh cache listI tried copying uv's CI setup as closely as I could, but that also does not fix the issue