Skip to content

Commit

Permalink
Add new museum (#522)
Browse files Browse the repository at this point in the history
* add MAA Cambridge

* add MAA number
  • Loading branch information
zsomborfoldi authored Jan 17, 2025
1 parent 92ad580 commit b8df9f9
Show file tree
Hide file tree
Showing 11 changed files with 99 additions and 48 deletions.
1 change: 1 addition & 0 deletions src/fragmentarium/domain/Fragment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ const config: Parameters<typeof Fragment['create']>[0] = {
pierpontMorganNumber: '123',
louvreNumber: '123',
dublinTcdNumber: '123',
cambridgeMaaNumber: '123',
alalahHpmNumber: '123',
australianinstituteofarchaeologyNumber: '123',
philadelphiaNumber: '123',
Expand Down
1 change: 1 addition & 0 deletions src/fragmentarium/domain/FragmentDtos.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export const ExternalNumberTypes = [
'pierpontMorganNumber',
'louvreNumber',
'dublinTcdNumber',
'cambridgeMaaNumber',
'alalahHpmNumber',
'australianinstituteofarchaeologyNumber',
'philadelphiaNumber',
Expand Down
6 changes: 6 additions & 0 deletions src/fragmentarium/domain/museum.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ export const Museums = {
country: 'TUR',
url: 'https://muze.gov.tr/muze-detay?SectionId=AMM01&DistId=AMM',
},
MUSEUM_OF_ARCHAEOLOGY_AND_ANTHROPOLOGY_CAMBRIDGE: {
name: 'Museum of Archaeology and Anthropology',
city: 'Cambridge',
country: 'GBR',
url: 'https://collections.maa.cam.ac.uk',
},
MUSEUM_OF_MONTSERRAT: {
name: 'Museum of Montserrat',
city: 'Montserrat',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ exports[`Snapshot 1`] = `
</p>
<p>
Excavation no.:
alfipa.1
kibetih.1
</p>
<p>
Provenance:
Tall al-Hawa
Tall Ajrab
</p>
</small>
</div>
Expand Down Expand Up @@ -5851,27 +5851,27 @@ exports[`Snapshot 1`] = `
class="fragment-result__fragment-number"
>
<a
href="/fragmentarium/zejherki.2"
href="/fragmentarium/pakfear.2"
>
zejherki.2
pakfear.2
</a>
(JN)
(Uruk4)
</h4>
<div
class="fragment-result__archaeology-info"
>
<small>
<p>
Accession no.:
ju.2
kudfera.2
</p>
<p>
Excavation no.:
zunab.2
sazkam.2
</p>
<p>
Provenance:
Tall Ghaḍaiyrīfah
Persepolis
</p>
</small>
</div>
Expand All @@ -5883,6 +5883,11 @@ exports[`Snapshot 1`] = `
class="text-secondary fragment-result__genre col-sm-4 col-12"
>
<ul>
<ul>
<small>
ARCHIVE ➝ Administrative ➝ Lists
</small>
</ul>
<ul>
<small>
Other ➝ Fake ➝ Certain
Expand Down Expand Up @@ -5944,14 +5949,14 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Checcucci & Tomlinson, 2027: 4727451873705984-8024100712742912
Pool & Franci, 2062: 915073268711424-3557031088750592
[
l. 3'., 1.
l. 1., 2.
]
<span
class="type-abbreviation"
>
(C)
(T)
</span>
</span>
</li>
Expand All @@ -5963,14 +5968,14 @@ exports[`Snapshot 1`] = `
<span
class="reference-popover__citation"
>
Chirici & Borchi, 2110: 7824054333472768-2832266722017280
Fernández & Maruyama, 2067: 681081137266688-1701799520108544
[
l. 3'., 4'.2.
l. 2., 4'.2.
]
<span
class="type-abbreviation"
>
(E)
(D)
</span>
</span>
</li>
Expand Down
9 changes: 9 additions & 0 deletions src/fragmentarium/ui/info/ExternalNumberLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,15 @@ export function dublinTcdLink({ number }: { number: string }): JSX.Element {
/>
)
}
export function cambridgeMaaLink({ number }: { number: string }): JSX.Element {
return (
<ExternalNumberLink
number={number}
baseUrl={'https://collections.maa.cam.ac.uk/objects/'}
label={'MAA Cambridge'}
/>
)
}
export function alalahHpmLink({ number }: { number: string }): JSX.Element {
return (
<ExternalNumberLink
Expand Down
8 changes: 8 additions & 0 deletions src/fragmentarium/ui/info/ExternalResources.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const metropolitanNumber = 'M123'
const pierpontMorganNumber = 'P123'
const louvreNumber = 'L123'
const dublinTcdNumber = 'L123'
const cambridgeMaaNumber = 'L123'
const alalahHpmNumber = 'L123'
const australianinstituteofarchaeologyNumber = 'L123'
const philadelphiaNumber = 'P123'
Expand Down Expand Up @@ -50,6 +51,7 @@ describe('external resources', () => {
pierpontMorganNumber,
louvreNumber,
dublinTcdNumber,
cambridgeMaaNumber,
alalahHpmNumber,
australianinstituteofarchaeologyNumber,
philadelphiaNumber,
Expand Down Expand Up @@ -113,6 +115,11 @@ describe('external resources', () => {
'https://digitalcollections.tcd.ie/concern/works/',
dublinTcdNumber,
],
[
'MAA Cambridge',
'https://collections.maa.cam.ac.uk/objects/',
cambridgeMaaNumber,
],
[
'Alalah HPM Number',
'https://www.hethport.uni-wuerzburg.de/Alalach/bildpraep.php?fundnr=',
Expand Down Expand Up @@ -171,6 +178,7 @@ describe('missing external resources', () => {
'Pierpont Morgan Library',
'Louvre',
'Trinity College Dublin',
'MAA Cambridge',
'Alalah HPM Number',
'Australian Institute of Archaeology',
'Penn Museum',
Expand Down
2 changes: 2 additions & 0 deletions src/fragmentarium/ui/info/ExternalResources.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
pierpontMorganLink,
LouvreLink,
dublinTcdLink,
cambridgeMaaLink,
alalahHpmLink,
australianinstituteofarchaeologyLink,
PhiladelphiaLink,
Expand Down Expand Up @@ -63,6 +64,7 @@ export default function ExternalResources({
[fragment.getExternalNumber('pierpontMorganNumber'), pierpontMorganLink],
[fragment.getExternalNumber('louvreNumber'), LouvreLink],
[fragment.getExternalNumber('dublinTcdNumber'), dublinTcdLink],
[fragment.getExternalNumber('cambridgeMaaNumber'), cambridgeMaaLink],
[fragment.getExternalNumber('alalahHpmNumber'), alalahHpmLink],
[
fragment.getExternalNumber('australianinstituteofarchaeologyNumber'),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,18 @@ exports[`external resources Snapshot 1`] = `
</a>
)
</li>
<li>
MAA Cambridge (
<a
aria-label="MAA Cambridge text L123"
href="https://collections.maa.cam.ac.uk/objects/L123"
rel="noopener noreferrer"
target="_blank"
>
L123
</a>
)
</li>
<li>
Alalah HPM Number (
<a
Expand Down
Loading

0 comments on commit b8df9f9

Please sign in to comment.