Fwddiff ret_activity canonicalizations #2271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimarsh6739
changed the title
wsmoses
reviewed
Apr 1, 2025
| class FwdRetDupNNToConstNN final : public OpRewritePattern<ForwardDiffOp> { | ||
| public: | ||
| using OpRewritePattern<ForwardDiffOp>::OpRewritePattern; | ||
|
|
There was a problem hiding this comment.
can we simplify this by having one pattern that does all of these, and not needing to create all the separate prologue/epilogues?
There was a problem hiding this comment.
We could do that, but i.m.o. the epilogue part becomes hairy (especially if we want to handle dup --> constnoneed - you are eliminating 2 return values as compared to 1). All transforms here strictly reduce number of args by 1.
I'll still give it a go.
wsmoses
reviewed
Apr 1, 2025
| @@ -19,6 +19,7 @@ target_link_libraries(enzymemlir-translate | |||
| MLIRSPIRVDialect | |||
| MLIRTranslateLib | |||
| MLIRSupport | |||
| "ZLIB::ZLIB" | |||
There was a problem hiding this comment.
cmake build fails without that, so for now I just added it as a quick fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies return activity whenever legal.
tagging @jhueckelheim