feat: upgrade to ArcGIS REST JS 4

[tomwayson]

1. Description:

TODO: before merging this, we must update the hub-common peer dependency to 17 in all packages, see below.

upgrade to ArcGIS REST JS 4

1. Instructions for testing:

• pull
• npm i
• npm run lint && npm run build
• npm test
• npm run e2e:node

NOTE: node tests will be fixed in a future PR, see comment below.

1. Closes Issues: https://devtopia.esri.com/dc/hub/issues/10768

2. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

3. used semantic commit messages

4. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

5. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

TODO: we need one more commit to do this before merging

[tomwayson]

tests pass in chrome, but node tests have over 500 failures, mostly w/ errors like Error: <spyOn> : getSelf is not declared writable or has no setter

It will take some time to figure out how to work around that, so for now I've disabled the Node tests. Very likely will need to fix this in a subsequent PR.

[tomwayson]

The solution.js team got around this by defining proxy functions, see: https://github.com/Esri/solution.js/blob/9d5833aaae6febb598ce78b3deb1ac0cafcd7cda/packages/common/src/arcgisRestJS.ts#L168

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (326925d) to head (2d31ba2).
Report is 23 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1850   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files         1061      1061           
  Lines        19206     19207    +1     
  Branches      3493      3493           
=========================================
+ Hits         19206     19207    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

[github-actions]

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.