-
Notifications
You must be signed in to change notification settings - Fork 14
feat(hub-common): expose the allowed channel ids field in the entity … #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
264e70f
to
6b127db
Compare
6b127db
to
033647b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No findings from the code review.
Just FYI, the documentation guide link in the PR description is broken for me. I'm assuming that is the same storybook I can see when I run the app locally, but wondering if I should be able to access that link.
Thanks for pointing that out @tommybramble, that's been outdated for some time. I've updated the PR template on this branch so that the |
27935d2
to
4c12211
Compare
affects: @esri/hub-common ISSUES CLOSED: 12668
…changes affects: @esri/hub-common ISSUES CLOSED: 12668
…discussion settings ui schema affects: @esri/hub-common ISSUES CLOSED: 12668
affects: @esri/hub-common ISSUES CLOSED: 12668
affects: @esri/hub-common ISSUES CLOSED: 12668
…on, discussion board participat affects: @esri/hub-common ISSUES CLOSED: 12668
affects: @esri/hub-common ISSUES CLOSED: 12668
This reverts commit 04d0534.
This reverts commit dd7ccfb.
…ma & uiSchema for group members affects: @esri/hub-common ISSUES CLOSED: 12787
affects: @esri/hub-common ISSUES CLOSED: 12787
affects: @esri/hub-common ISSUES CLOSED: 12787
…chemaDiscussionSettings uischem affects: @esri/hub-common ISSUES CLOSED: 12875
… Members, Group => Members & Gr affects: @esri/hub-common ISSUES CLOSED: 12913
0232adf
to
df86b7c
Compare
Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependencies
as needed. CRITICAL our automated release system can not be counted on to updatepeerDependencies
so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.