Skip to content

feat(hub-common): expose the allowed channel ids field in the entity … #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

rweber-esri
Copy link
Contributor

  1. Description:
  • Exposes the allowed channel ids field in the discussion board discussion settings ui schema hub-premium users
  1. Instructions for testing:

  2. Closes Issues: # (if appropriate)

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@rweber-esri rweber-esri changed the base branch from f/12668-add-entity-discussion-settings-schema to master April 3, 2025 03:16
@rweber-esri rweber-esri force-pushed the f/discussions-v1-to-v2 branch 2 times, most recently from 264e70f to 6b127db Compare April 3, 2025 14:21
@rweber-esri rweber-esri force-pushed the f/discussions-v1-to-v2 branch from 6b127db to 033647b Compare April 7, 2025 12:38
Copy link

@tommybramble tommybramble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings from the code review.

Just FYI, the documentation guide link in the PR description is broken for me. I'm assuming that is the same storybook I can see when I run the app locally, but wondering if I should be able to access that link.

@rweber-esri
Copy link
Contributor Author

rweber-esri commented Apr 7, 2025

Just FYI, the documentation guide link in the PR description is broken for me. I'm assuming that is the same storybook I can see when I run the app locally, but wondering if I should be able to access that link.

Thanks for pointing that out @tommybramble, that's been outdated for some time. I've updated the PR template on this branch so that the Documentation Guide link points here. The URL change won't be reflected though until this PR merges.

@rweber-esri rweber-esri force-pushed the f/discussions-v1-to-v2 branch 2 times, most recently from 27935d2 to 4c12211 Compare April 11, 2025 19:03
affects: @esri/hub-common

ISSUES CLOSED: 12668
…changes

affects: @esri/hub-common

ISSUES CLOSED: 12668
…discussion settings ui schema

affects: @esri/hub-common

ISSUES CLOSED: 12668
affects: @esri/hub-common

ISSUES CLOSED: 12668
affects: @esri/hub-common

ISSUES CLOSED: 12668
…on, discussion board participat

affects: @esri/hub-common

ISSUES CLOSED: 12668
affects: @esri/hub-common

ISSUES CLOSED: 12668
…ma & uiSchema for group members

affects: @esri/hub-common

ISSUES CLOSED: 12787
affects: @esri/hub-common

ISSUES CLOSED: 12787
affects: @esri/hub-common

ISSUES CLOSED: 12787
…chemaDiscussionSettings uischem

affects: @esri/hub-common

ISSUES CLOSED: 12875
… Members, Group => Members & Gr

affects: @esri/hub-common

ISSUES CLOSED: 12913
@rweber-esri rweber-esri force-pushed the f/discussions-v1-to-v2 branch from 0232adf to df86b7c Compare April 11, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants