Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: support basic column operations #3362

Merged
merged 1 commit into from
Dec 4, 2024

[FEAT] connect: support basic column operations

a0165a6
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] connect: support basic column operations #3362

[FEAT] connect: support basic column operations
a0165a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 4, 2024 in 0s

77.33% (-0.06%) compared to 83470e0

View this Pull Request on Codecov

77.33% (-0.06%) compared to 83470e0

Details

Codecov Report

Attention: Patch coverage is 25.44379% with 126 lines in your changes missing coverage. Please review.

Project coverage is 77.33%. Comparing base (83470e0) to head (a0165a6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/translation/datatype.rs 7.96% 104 Missing ⚠️
src/daft-connect/src/translation/expr.rs 50.00% 18 Missing ⚠️
...onnect/src/translation/expr/unresolved_function.rs 80.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3362      +/-   ##
==========================================
- Coverage   77.39%   77.33%   -0.06%     
==========================================
  Files         696      696              
  Lines       84549    84716     +167     
==========================================
+ Hits        65438    65517      +79     
- Misses      19111    19199      +88     
Files with missing lines Coverage Δ
src/daft-connect/src/lib.rs 64.21% <ø> (ø)
...onnect/src/translation/expr/unresolved_function.rs 64.70% <80.00%> (+64.70%) ⬆️
src/daft-connect/src/translation/expr.rs 57.14% <50.00%> (+1.00%) ⬆️
src/daft-connect/src/translation/datatype.rs 10.40% <7.96%> (+2.99%) ⬆️

... and 4 files with indirect coverage changes