-
Notifications
You must be signed in to change notification settings - Fork 92
Kosovic Model - Multiphase Support #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hgopalan
wants to merge
11
commits into
Exawind:main
Choose a base branch
from
hgopalan:multiphase-turbulence
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rybchuk Thank you for the test cases. It was very helpful. |
Adding the changes to the Kosovic model would make the code too cluttered. This was the reason for a separate model. |
Added test case |
documentation done |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing LES models overpredict turbulent viscosity near the interface for multiphase flow simulations. This arises due to the inconsistency between the ABL profile and the profile specified in the ocean. To enable turbulence in the ocean, there has to be a consistent initial profile between atmosphere and ocean to avoid over-prediction of the turbulence diffusion terms due to initial condition generated shear and buoyancy production.
The multi-phase model handles this incompatibility and ensures that the diffusion term do not cause a drop in the time step. The following changes are made
The multiphase solver runs at 1/3rd of the time step when compared to the single phase immersed forcing wave model. The maximum possible Aspect Ratio is ~ 2-3. Solver fails at AR=4 with JONSWAP spectrum.
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Linear Waves
Issue Number: #1462