-
Notifications
You must be signed in to change notification settings - Fork 92
Post processing output upgrade #1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Still need to set up the functionality to limit the timestep size, but that should follow after #1542. Other things to figure out include how to interact with the time tolerances from other outputs (checkpoint and plotfiles). |
Also, I'm wondering if this would be a good PR to move non-sampling outputs (KineticEnergy, Enstrophy, etc.) out of the sampling/ directory. |
Both are in there now. Needs some manual testing and unit testing. And documentation. |
probably would be too confusing to do this here |
need to also have it output at the end of a simulation!! |
Summary
Following on from a usability request from the last user meeting, this PR introduces a common approach to determine when postprocessing should be output and introduces new features (delay, time-based output, etc.)
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: