Skip to content

Post processing output upgrade #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Apr 23, 2025

Summary

Following on from a usability request from the last user meeting, this PR introduces a common approach to determine when postprocessing should be output and introduces new features (delay, time-based output, etc.)

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number:

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Apr 23, 2025

Still need to set up the functionality to limit the timestep size, but that should follow after #1542.

Other things to figure out include how to interact with the time tolerances from other outputs (checkpoint and plotfiles).

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Apr 23, 2025

Also, I'm wondering if this would be a good PR to move non-sampling outputs (KineticEnergy, Enstrophy, etc.) out of the sampling/ directory.

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Apr 23, 2025

Still need to set up the functionality to limit the timestep size, but that should follow after #1542.

Other things to figure out include how to interact with the time tolerances from other outputs (checkpoint and plotfiles).

Both are in there now. Needs some manual testing and unit testing. And documentation.

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Apr 23, 2025

Also, I'm wondering if this would be a good PR to move non-sampling outputs (KineticEnergy, Enstrophy, etc.) out of the sampling/ directory.

probably would be too confusing to do this here

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Apr 25, 2025

need to also have it output at the end of a simulation!!

@mbkuhn mbkuhn marked this pull request as ready for review May 6, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant