Update OF 40 API #1595
Merged
Update OF 40 API #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openfast is being updated here in spack: spack/spack#50228 |
|
This Exawind/exawind-manager#297 was merged, everything seems to be building. |
jrood-nrel
approved these changes
Apr 29, 2025
|
This is going to break building against OF 4.0.0 - 4.0.3. The latest exawind manager will guard against building those versions... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OpenFast has a bug in their API: OpenFAST/openfast#2776. There's a mismatch of arguments btw the C++ declaration and fortran definition. Once that fix gets merged, we can merge this PR.
Pull request type
Please check the type of change introduced:
Closes #1591