Improve notifications sending logging #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log for sending notification does not cover all cases of unsuccessful sending. It is difficult to understand the reason for the unsuccessful sending for non debug environments.
|
Hi @ivanmaterov Why you can’t just set logging level DEBUG for aioapns’s logger? |
|
Hi @Fatal1ty |
|
@Fatal1ty It also helps to bring the code into a consistent form. It's strange that one exception is handled as a debug, and the other is not handled at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced the problem that several notifications were not sent and I don't understand the reason.
I propose to improve logging so that all cases of unsuccessful sends are displayed in warnigs.