WIP/PAUSED: Refactor verification layer #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tordans
force-pushed
the
redownload-issue
branch
from
bd6c40b to
bc79631
Compare
- the setFeatureState does not work, yet - as a result, everything is styled blue - I think the issue is, to give the features an feature.id, which I think we do not have ATM (only features.properties.osm_id) ALSO - ATM the code that also add the feature to a locale store is removed - we need to re-add this, so we can check the local feature store for the correct inspector state - we want to move the setFeatureState to addLocalUpdate, probably, so we do both in one place…
tordans
force-pushed
the
redownload-issue
branch
from
bc79631 to
d2a66c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status in bc79631