Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding): Add API to support onboarding support request #5331

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Apr 11, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Create two APIs: one for sending onboarding support requests from self-hosted instances, and another for receiving those requests and pushing the data to HubSpot.

How did you test this code?

Adds unit tests

@gagantrivedi gagantrivedi requested a review from a team as a code owner April 11, 2025 06:54
@gagantrivedi gagantrivedi requested review from emyller and removed request for a team April 11, 2025 06:54
Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 7:47am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 7:47am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 7:47am

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Apr 11, 2025
Copy link
Contributor

github-actions bot commented Apr 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5331 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5331 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5331 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5331 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5331 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5331 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Apr 11, 2025

Uffizzi Ephemeral Environment deployment-62688

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5331

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 14, 2025
@gagantrivedi
Copy link
Member Author

gagantrivedi commented Apr 14, 2025

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (3a98aca) to head (1fb020f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5331      +/-   ##
==========================================
+ Coverage   97.53%   97.60%   +0.06%     
==========================================
  Files        1225     1234       +9     
  Lines       42551    42848     +297     
==========================================
+ Hits        41503    41821     +318     
+ Misses       1048     1027      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 14, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 14, 2025
@api_view(["POST"])
@permission_classes([IsAdminUser])
def send_onboarding_request_to_saas_flagsmith_view(request: Request) -> Response:
admin_user: FFAdminUser = request.user # type: ignore[assignment]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khvn26 Did you run into this typing error as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a known (and annoying) issue described here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants