-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(onboarding): Add API to support onboarding support request #5331
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5331 +/- ##
==========================================
+ Coverage 97.53% 97.60% +0.06%
==========================================
Files 1225 1234 +9
Lines 42551 42848 +297
==========================================
+ Hits 41503 41821 +318
+ Misses 1048 1027 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@api_view(["POST"]) | ||
@permission_classes([IsAdminUser]) | ||
def send_onboarding_request_to_saas_flagsmith_view(request: Request) -> Response: | ||
admin_user: FFAdminUser = request.user # type: ignore[assignment] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khvn26 Did you run into this typing error as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's a known (and annoying) issue described here
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Create two APIs: one for sending onboarding support requests from self-hosted instances, and another for receiving those requests and pushing the data to HubSpot.
How did you test this code?
Adds unit tests