Introduce new multi stage Docker image for DB component #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates main
Dockerfile
to utilize multiple stages and build the binary inside the image as part of the build stage.This should result in better developer experience and more reproducible builds.
If users want to use binary which has been pre-compiled locally outside the image (aka on host), they can do that
Dockerfile.pre_compiled
Dockerfile.That one is almost the same as the original Dockerfile. I just added a check to fail in case the binary hasn't been correctly compiled locally (e.g. with
xgo
formusl
or usingCGO_ENABLED=0
).I also included a GHA workflow which builds the images to verify those files are working.
We could extend the original release workflow to build and push development version of images to Docker Hub / GHCR on each
main
branch run (we can use git commit sha as the image tag).TODO
Related PRs
Links