-
-
Notifications
You must be signed in to change notification settings - Fork 93
[talker_riverpod_logger] add support for Riverpod 3.0.0(-Dev) #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis pull request updates the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DmitrySboychakov - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Hello @DmitrySboychakov ! |
And could you please help me resolve the merge conflicts, @DmitrySboychakov? |
@Frezyx sounds about right! |
There is new Riverpod 3.0.0 release in near future, that contain breaking changes to the Provider Observers.
This PR request update package code to work with 3.0.0-Dev version that currently published (should work with release version once published as well)
Summary by Sourcery
Update talker_riverpod_logger package to support Riverpod 3.0.0-Dev with breaking changes to Provider Observers
New Features:
Enhancements:
Chores: