chore!: upgrade commander to12.1.0 (#2620)

* fix(fuels): removed -p flag, bumped commander dep to latest * change version in lock file * Update seven-moles-live.md * Update .changeset/seven-moles-live.md Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk> --------- Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
FuelLabs · Jun 26, 2024 · a6c45fd · a6c45fd
1 parent c846bfb
commit a6c45fd
Show file tree

Hide file tree

Showing 11 changed files with 52 additions and 204 deletions.
diff --git a/.changeset/seven-moles-live.md b/.changeset/seven-moles-live.md
@@ -0,0 +1,7 @@
+---
+"fuels": minor
+"create-fuels": patch
+"@fuel-ts/abi-typegen": patch
+---
+
+chore!: upgrade `commander` to`12.1.0`
diff --git a/apps/docs/src/guide/fuels-cli/commands.md b/apps/docs/src/guide/fuels-cli/commands.md
@@ -61,7 +61,7 @@ npx fuels@{{fuels}} help build
 
 ```console
 Options:
-  -p, --path <path>  Path to project root (default: "/Users/anderson/Code/fuel/fuels-ts/apps/docs")
+  --path <path>  Path to project root (default: "/Users/anderson/Code/fuel/fuels-ts/apps/docs")
   -d, --deploy       Deploy contracts after build (auto-starts a `fuel-core` node if needed)
   -h, --help         Display help
 ```

diff --git a/packages/abi-typegen/package.json b/packages/abi-typegen/package.json
@@ -55,7 +55,7 @@
     "@fuel-ts/interfaces": "workspace:^",
     "@fuel-ts/utils": "workspace:*",
     "@fuel-ts/versions": "workspace:*",
-    "commander": "^9.4.1",
+    "commander": "12.1.0",
     "glob": "^10.2.6",
     "handlebars": "^4.7.8",
     "mkdirp": "^1.0.4",

diff --git a/packages/create-fuels/package.json b/packages/create-fuels/package.json
@@ -21,7 +21,7 @@
   "dependencies": {
     "@iarna/toml": "^2.2.5",
     "chalk": "4",
-    "commander": "^9.4.1",
+    "commander": "12.1.0",
     "ora": "5.4.1",
     "prompts": "^2.4.2"
   },

diff --git a/packages/fuels/package.json b/packages/fuels/package.json
@@ -68,7 +68,7 @@
     "bundle-require": "^5.0.0",
     "chalk": "4",
     "chokidar": "^3.5.3",
-    "commander": "^9.4.1",
+    "commander": "12.1.0",
     "esbuild": "^0.19.3",
     "glob": "^10.2.6",
     "handlebars": "^4.7.8",

diff --git a/packages/fuels/src/cli.ts b/packages/fuels/src/cli.ts
@@ -42,7 +42,7 @@ export const configureCli = () => {
    * Defining local commands
    */
 
-  const pathOption = new Option('-p, --path <path>', 'Path to project root').default(process.cwd());
+  const pathOption = new Option('--path <path>', 'Path to project root').default(process.cwd());
 
   let command: Command;
 

diff --git a/packages/fuels/src/cli/commands/withBinaryPaths.test.ts b/packages/fuels/src/cli/commands/withBinaryPaths.test.ts
@@ -1,4 +1,4 @@
-import { program } from 'commander';
+import { Command } from 'commander';
 
 import { fuelsConfig } from '../../../test/fixtures/fuels.config';
 import { mockLogger } from '../../../test/utils/mockLogger';
@@ -12,9 +12,9 @@ const mockAllDeps = (
 ) => {
   const { forcPath, fuelCorePath, configPath } = params;
 
-  const command = program
+  const command = new Command()
     .command(Commands.versions)
-    .option('-p, --path <path>', 'Path to project root', configPath);
+    .option('--path <path>', 'Path to project root', configPath);
 
   const runVersions = vi.fn();
 

diff --git a/packages/fuels/src/cli/commands/withConfig.test.ts b/packages/fuels/src/cli/commands/withConfig.test.ts
@@ -1,4 +1,4 @@
-import { program } from 'commander';
+import { Command } from 'commander';
 
 import { fuelsConfig } from '../../../test/fixtures/fuels.config';
 import { mockLogger } from '../../../test/utils/mockLogger';
@@ -32,9 +32,9 @@ describe('withConfig', () => {
 
     const configPath = '/a/real/path';
 
-    const command = program
+    const command = new Command()
       .command(Commands.deploy)
-      .option('-p, --path <path>', 'Path to project root', configPath);
+      .option('--path <path>', 'Path to project root', configPath);
 
     const loadConfig = vi.spyOn(loadConfigMod, 'loadConfig').mockImplementation(() => {
       if (params?.shouldErrorOnLoadConfig) {

diff --git a/packages/fuels/test/features/init.test.ts b/packages/fuels/test/features/init.test.ts
@@ -88,7 +88,7 @@ describe('init', () => {
     const write = vi.spyOn(process.stdout, 'write').mockReturnValue(true);
     const exit = vi.spyOn(process, 'exit').mockResolvedValue({} as never);
 
-    await runCommand(Commands.init, ['-p', paths.root, '-o', paths.outputDir]);
+    await runCommand(Commands.init, ['--path', paths.root, '-o', paths.outputDir]);
 
     expect(exit).toHaveBeenCalledTimes(1);
     expect(exit).toHaveBeenCalledWith(1);

diff --git a/packages/fuels/test/utils/runCommands.ts b/packages/fuels/test/utils/runCommands.ts
@@ -114,7 +114,7 @@ export async function runInit(params: InitParams) {
     value ? (flags as string[]) : [];
 
   const flags = [
-    flag(['-p', root], root),
+    flag(['--path', root], root),
     flag(['-o', output], output),
     flag(['-w', workspace], workspace),
     flag(['--contracts', contracts], contracts),
@@ -130,16 +130,16 @@ export async function runInit(params: InitParams) {
 
 export async function runBuild(params: BuildParams) {
   const { root, deploy } = params;
-  const flags = [['-p', root], deploy ? ['--deploy'] : []].flat();
+  const flags = [['--path', root], deploy ? ['--deploy'] : []].flat();
   return runCommand(Commands.build, flags);
 }
 
 export async function runDeploy(params: BaseParams) {
-  return runCommand(Commands.deploy, ['-p', params.root]);
+  return runCommand(Commands.deploy, ['--path', params.root]);
 }
 
 export async function runDev(params: BaseParams) {
-  return runCommand(Commands.dev, ['-p', params.root]);
+  return runCommand(Commands.dev, ['--path', params.root]);
 }
 
 /**