-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: stop piping into process.stdout/stderr
and use console.log
#2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
commented
Jun 19, 2024
nedsalk
commented
Jun 19, 2024
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
petertonysmith94 and
maschad
as code owners
June 19, 2024 16:45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to update all process.stdout
to console.log
?
@petertonysmith94 I can do that in this PR, I'll put it into draft mode until it's ready again. |
nedsalk
changed the title
fix: error disappearing on
fix: stop piping into Jun 27, 2024
fuels init
commandprocess.stdout/stderr
and use console.log
nedsalk
force-pushed
the
ns/fix/stop-silencing-errors-fuels-init
branch
from
June 27, 2024 10:22
65e4d5e
to
aa25af1
Compare
nedsalk
commented
Jun 27, 2024
nedsalk
commented
Jun 27, 2024
nedsalk
dismissed stale reviews from petertonysmith94, maschad, and arboleya
via
July 1, 2024 08:35
edb4fe4
nedsalk
force-pushed
the
ns/fix/stop-silencing-errors-fuels-init
branch
from
July 1, 2024 10:22
e31fb99
to
f4f98ef
Compare
Torres-ssf
reviewed
Jul 1, 2024
Torres-ssf
previously approved these changes
Jul 1, 2024
nedsalk
changed the title
fix: stop piping into
fix!: stop piping into Jul 2, 2024
process.stdout/stderr
and use console.log
process.stdout/stderr
and use console.log
Torres-ssf
approved these changes
Jul 2, 2024
maschad
approved these changes
Jul 2, 2024
Coverage Report:
Changed Files:
|
arboleya
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substitutes
process.stdout
andprocess.stderr
usage withconsole.log
in our whole codebase because the logs would sometimes get removed once the process finishes.fuels init
command #2483launchNode
startup #2248Breaking changes
Removed
debugEnabled
property fromlaunchNode
inputs, which was used to read fromstdout
which isn't used byfuel-core
internally.