Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added onBeforeSend hook to the connector interface #3487

Merged
merged 18 commits into from
Jan 10, 2025

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Dec 16, 2024

Relates to: FuelLabs/fuel-connectors#451

Summary

  • Added onBeforeSend to the account sendTransaction method, to allow for altering of a transaction request before submission.
  • Added onCustomFee to enable skipping "customFee" calculations in Fuel Wallet.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 10:44am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 10:44am
ts-docs-api 🛑 Canceled (Inspect) Jan 10, 2025 10:44am

@github-actions github-actions bot added the chore Issue is a chore label Dec 16, 2024
@petertonysmith94 petertonysmith94 changed the title chore: added feat: added onBeforeSend hook to the connector interface Dec 16, 2024
@github-actions github-actions bot added the feat Issue is a feature label Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

This PR is published in NPM with version 0.0.0-pr-3487-20250109192939

@maschad maschad changed the title feat: added onBeforeSend hook to the connector interface feat: added onBeforeSend hook to the connector interface Dec 16, 2024
@nedsalk nedsalk self-requested a review January 10, 2025 08:37
nedsalk
nedsalk previously approved these changes Jan 10, 2025
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.98%(+0.08%) 70.46%(+0.11%) 75.05%(+0.16%) 76.98%(+0.08%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 80.58%
(+2.35%)
69.86%
(+4.59%)
82.5%
(+2.5%)
80.34%
(+2.31%)
🔴 packages/account/src/connectors/fuel.ts 96.73%
(+1.31%)
90.66%
(+0%)
93.33%
(+4.45%)
96.85%
(+1.26%)

@arboleya arboleya merged commit 0f138cd into master Jan 10, 2025
24 checks passed
@arboleya arboleya deleted the ps/chore/added-on-before-send-hook branch January 10, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants