Skip to content

Fix-refactor file structure for improved code quality around cli testing #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

gadyrcdz
Copy link

@gadyrcdz gadyrcdz commented Apr 30, 2025

-Fixing issue #5459

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • If my change requires substantial documentation changes, I have requested support from the DevRel team
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@gadyrcdz gadyrcdz requested a review from a team as a code owner April 30, 2025 05:33
@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Apr 30, 2025

Thanks for the contribution! Before we can merge this, we need @gadyrcdz to sign the Fuel Labs Contributor License Agreement.

Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I don't think the tests can pass like this. You also need to update the tests that reads from test/data so that they read from tests/data.

@gadyrcdz gadyrcdz requested a review from kayagokalp May 1, 2025 04:57
@gadyrcdz
Copy link
Author

gadyrcdz commented May 1, 2025

Thanks for the PR. I don't think the tests can pass like this. You also need to update the tests that reads from test/data so that they read from tests/data.

Hello, sir, sorry for the misunderstanding. I changed all the files that needed the new route. And the test of forc-client runs
correctly. Let me know if there's something wrong, and I'll fix it. Thank you for the opportunity!

@gadyrcdz gadyrcdz temporarily deployed to fuel-sway-bot May 5, 2025 09:52 — with GitHub Actions Inactive
@xunilrj
Copy link
Contributor

xunilrj commented May 19, 2025

Let me know if there's something wrong, and I'll fix it.

There are still CI tests failing. @gadyrcdz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants