-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tinker's Construct manuals, Dreamcraft edition #797
Conversation
4a58fb7
to
6fbc577
Compare
src/main/java/com/dreammaster/recipes/ShapedIngredientsResolver.java
Outdated
Show resolved
Hide resolved
Good job! More customizable books is always great. One comment about code: I found multiple classes and methods with package-private visibility. Please, set explicit visibility for these ones (where possible) and comment where package-private visibility is intended. |
I couldn't find a package-private class member I wrote that didn't have that visibility on purpose, I've made absolutely everything I could private. In cases where I didn't actually call package private methods from other classes in that package but used them in tests, I annotated these methods with As for public members I try to have them implement an interface as much as possible, so most of them will have Can you clarify what kind of documentation you're expecting to see? Should I annotate them both package-private and public methods with their reason for not being private? |
I can definitely document why the classes themselves are package-private, that makes sense. |
And come to think of it, it's probably better for GameRegistry to be public since it's meant to be used with Recipe which is also public. Let me know what you think. |
…se with recipe registries.
be5d9d1
to
d1c2ae4
Compare
This PR does 3 things:
It is dependent on GTNewHorizons/TinkersConstruct#109 to fully take effect.
The list of content changes is too large to list here but it can be determined from commits that change the baseline lang entries added in this PR.
Known issues:
Sample screenshots