-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colorbar: Add modifier +n|N to -D option for placing colorbar NaN box on the right and to skip label #8287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, let argument - mean no NaN label.
PaulWessel
added
documentation
Improve documentation
enhancement
Improving an existing feature
labels
Jan 12, 2024
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added images
Modified images
Report last updated at commit a1fe9aa |
Add the |
PaulWessel
changed the title
Add modifier for placing colorbar NaN box on the right and to skip label
colorbar: Add modifier +n|N to -D option for placing colorbar NaN box on the right and to skip label
Jan 12, 2024
joa-quim
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add-changelog
Add PR to the changelog
documentation
Improve documentation
enhancement
Improving an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new modifier for placing a NaN-color box and NAN label at the end of the color bar is now extended to
+n|N[-|label]
where the new +N means place it on the right side of the bar (top for vertical bars) and if the label is - we do not place any label. Default is still NaN unless you append an alternative label.
Added two new test scripts
psscale/colorbar-nans-h.sh
andpsscale/colorbar-nans-v.sh
to ensure it works for both horizontal and vertical bars.