Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the incompatibility (regression) between the -I and -Q options. #8643

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

joa-quim
Copy link
Member

See forum post
https://forum.generic-mapping-tools.org/t/grdimage-transparency-of-nan-values/5641/11

But testing this further would be good. There must have been some reason to exclude the -I -Q combination.

See forum post
 https://forum.generic-mapping-tools.org/t/grdimage-transparency-of-nan-values/5641/11

But testing this further would be good. There must have been some reason to exclude the -I -Q combination.
@joa-quim joa-quim requested a review from a team December 15, 2024 22:31
@seisman
Copy link
Member

seisman commented Dec 16, 2024

These codes were initially added in #8241 and #8251

@joa-quim
Copy link
Member Author

Yes, I guessed so but unless we find a good reason to keep it (the -Q -I conflict) we should remove it. And even if we find, we may restrict that eventual case under an appropriate code condition.

Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new failures. So good to merge.

@joa-quim joa-quim merged commit b34b125 into master Dec 16, 2024
15 of 18 checks passed
@joa-quim joa-quim deleted the rem-I-Q-incompatibility branch December 16, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants