Replace deprecated CURLINFO_CONTENT_LENGTH_DOWNLOAD

[remkos]

Description of proposed changes

Compiling on MacOS gave this warning:

src/gmt_remote.c:680:41: warning: 'CURLINFO_CONTENT_LENGTH_DOWNLOAD' is deprecated: since 7.55.0. Use CURLINFO_CONTENT_LENGTH_DOWNLOAD_T [-Wdeprecated-declarations]
  680 |                         res = curl_easy_getinfo (curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD, &filesize);
      |                                                        ^

So I have replaced CURLINFO_CONTENT_LENGTH_DOWNLOAD by CURLINFO_CONTENT_LENGTH_DOWNLOAD_T and changed the type of filesize from double to curl_off_t.

The addresses #8653

Reminders

• Make sure that your code follows our style. Use the other functions/files as a basis.
• Add tests for new features or tests that would have caught the bug that you're fixing.
• Describe changes to function behavior and arguments in a comment below the function declaration.
• If adding new functionality, add a detailed description to the documentation and/or an example.

[seisman]

Yes, it's deprecated since curl 7.55 (https://curl.se/libcurl/c/CURLINFO_CONTENT_LENGTH_DOWNLOAD.html), and curl 7.55 was released in 2017 (https://curl.se/docs/releases.html), so I think it should be good.

Maybe we should also set the minimum required curl version in the following line

gmt/src/CMakeLists.txt

Line 143 in 79800bd

find_package (CURL REQUIRED)

[remkos]

Yes, that minimum curl version would be 7.55.0 then. I'll work out how to do that and add to the PR.

[remkos]

@seisman: Done as requested

[seisman]

Looks good to me.

[seisman]

@remkos Next time, you can just ping @GenericMappingTools/gmt-maintainers for code reviews.

This team contains people who maintain/change the codes. See https://github.com/orgs/GenericMappingTools/teams/gmt-maintainers for the list of people.

On the other hand, if you want to be pinged for PR reviews, I can also add you to the team.

[remkos]

Thanks for the suggestions, @seisman. I have already added myself to @GenericMappingTools/gmt-contributors and will use that in future review requests.

[joa-quim]

We should have only one group for asking reviews. The way we have it it's too confusing what-is-what-and-what-for.