Skip to content

Add base-denied-permissions section to standalone command manager #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

onebeastchris
Copy link
Member

No description provided.

@onebeastchris onebeastchris requested a review from Konicai July 11, 2025 00:25
Copy link
Member

@Konicai Konicai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main API difference I see here is that:

Before: Order of subscribers to RegisterPermissionsEvent did not matter. Additionally, default=true would always essentially be taken over default=false. I think this might've been a bad decision on my part...

Current changes: When an earlier subscriber chooses default=true or default=false, that sticks.

I think it might be nice if the caller is notified that their permission registration failed? Or should later subscribers override existing values?

Happy to help discuss :)

@onebeastchris
Copy link
Member Author

@Konicai Good point. I've changed it now to allow later method callers to override the default. As for notifications - i don't think they'd be too useful, but i did add debug logging to make such cases easier to identify. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants