-
Notifications
You must be signed in to change notification settings - Fork 1
add captain_utility for upgrading helm #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new utility script to support an interactive helm upgrade process for specific components.
- Implements interactive version selection for "argocd" and "glueops-platform".
- Executes helm diff, confirms the upgrade via gum, applies the helm upgrade, and uploads the diff output.
Comments suppressed due to low confidence (1)
.devcontainer/tools/captain_utility.sh:13
- [nitpick] Consider renaming 'argocd_version' to 'argocd_versions' to better reflect that the variable holds multiple version values.
local argocd_version=($(helm search repo argo/argo-cd --versions -o json | jq -r "limit(30; .[]).version" | paste -sd' ' -))
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@hamzabouissi see AI feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See AI feedback.
Also, we can make another PR for this but would it be low effort to add these features to the tool: http://glueops.getoutline.com/doc/argocd-app-repairs-P63ZXVxOTu ?
PR Type
enhancement
Description
Add
captain_utility.sh
script for interactive Helm upgradesEnable version selection and diff viewing for ArgoCD and GlueOps Platform
Integrate user confirmation and upgrade application steps
Prepare for uploading Helm diff output (placeholder function)
Changes walkthrough 📝
captain_utility.sh
Add interactive Helm upgrade and diff script
.devcontainer/tools/captain_utility.sh