update message class add #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnarLito
commented
Nov 22, 2021
| @@ -58,7 +58,4 @@ def _from_data(self, data): | |||
|
|
|||
| def _sync(self): | |||
| self.message_groups = [MessageGroup(state=self._state, data=group) for group in self._state.http.get_all_group_messages()] | |||
There was a problem hiding this comment.
Issue:
- unnessesery onload overhead (since is wont be used much)
- dynamic data, meaning that the user can join and leave groups at runtime
ToDo:
- set
self.message_groupsto class onlyself._message_groups - move group building to State machine #7
|
Solved by #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
begin for adding message class to client user.
TODO:
can I get it a another way then search or message group?