Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the theme for GodotPanelApp to match the one used by GodotApp #287

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

m4gr3d
Copy link
Collaborator

@m4gr3d m4gr3d commented Mar 25, 2025

GodotPanelApp is only included in the manifest from a Godot editor build, so we can assume that when it's enabled, GodotApp and its theme resources will always be available.

`GodotPanelApp` is only included in the manifest from a Godot editor build, so we can assume that when it's enabled, `GodotApp` and its theme resources will always be available.
@m4gr3d m4gr3d added bug Something isn't working enhancement New feature or request labels Mar 25, 2025
@m4gr3d m4gr3d added this to the 4.0.0 milestone Mar 25, 2025
@m4gr3d
Copy link
Collaborator Author

m4gr3d commented Mar 25, 2025

@dsnopek This also addresses a build issue that occurs when using the vendors plugin library in an Android project that doesn't have a dependency on the splashscreen library.

Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine!

This also addresses a build issue that occurs when using the vendors plugin library in an Android project that doesn't have a dependency on the splashscreen library.

Don't we require the splashscreen library? I'm not sure I understand how a Godot Android app wouldn't depend on it

That said, having less stuff is good :-)

@m4gr3d m4gr3d merged commit 287b8c1 into GodotVR:master Mar 26, 2025
11 checks passed
@m4gr3d m4gr3d deleted the update_panel_theme branch March 26, 2025 16:24
@m4gr3d
Copy link
Collaborator Author

m4gr3d commented Mar 26, 2025

Don't we require the splashscreen library? I'm not sure I understand how a Godot Android app wouldn't depend on it

The splashscreen library is added as an implementation dependency for the plugin, so it's included automatically both at compile-time and runtime.

What's not included however are the splashscreen library resources that define the postSplashScreenTheme theme attribute. So when another project with a dependency to the vendor plugin library tries to compile without a dependency to the splashscreen library, the missing theme attribute definition causes a build error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants