Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert OpenXrFbFaceTrackingExtensionWrapper to drive an XRFaceTracker. #92

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Malcolmnixon
Copy link
Contributor

@Malcolmnixon Malcolmnixon commented Feb 19, 2024

This PR depends upon godotengine/godot#88312 to provide the XRFaceTracker and XRFaceModifier3D types. Until they are available and merged in, building the code requires:

  1. Building Godot with the XRFaceTracker and XRFaceModifier3D nodes.
  2. Running Godot with --dump-extension-api an overwriting the godot_cpp extension_api.json file
  3. Building godot_openxr_vendors

The following video demonstrates the results:

2024-02-25.13-44-09.mp4

@Malcolmnixon Malcolmnixon force-pushed the openxr-fb-xr-face-tracker branch from 9b0572d to 0b64260 Compare February 19, 2024 02:42
@m4gr3d m4gr3d added this to the 3.0.0 milestone Feb 19, 2024
@m4gr3d m4gr3d added the enhancement New feature or request label Feb 19, 2024
@Malcolmnixon Malcolmnixon force-pushed the openxr-fb-xr-face-tracker branch 2 times, most recently from 9f74af2 to e0f0a26 Compare February 25, 2024 18:46
@Malcolmnixon
Copy link
Contributor Author

This PR has been updated to use XR_FB_face_tracking2 which adds basic support for tongue position.

@Malcolmnixon Malcolmnixon force-pushed the openxr-fb-xr-face-tracker branch from e0f0a26 to 4df311d Compare February 27, 2024 02:01
@Malcolmnixon Malcolmnixon marked this pull request as ready for review February 27, 2024 03:03
@Malcolmnixon
Copy link
Contributor Author

Rebased to give access to the new Godot 4.3-dev.3 types.

@m4gr3d m4gr3d merged commit ff5be85 into GodotVR:master Feb 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants