Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the gdextension api json to Godot 4.3 dev3 #95

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Update the gdextension api json to Godot 4.3 dev3 #95

merged 1 commit into from
Feb 26, 2024
+292,091 −19

Conversation

m4gr3d
Copy link
Collaborator

@m4gr3d m4gr3d commented Feb 25, 2024 •
edited
Loading

  • Updated godot-cpp submodule with the latest from the https://github.com/godotengine/godot-cpp/master branch
  • Added a custom extension_api.json generated from a godotengine/godot@81f3d43 build
  • Updated the README and build workflows to use the custom extension_api.json

@m4gr3d m4gr3d added the enhancement New feature or request label Feb 25, 2024
@m4gr3d m4gr3d added this to the 3.0.0 milestone Feb 25, 2024
@m4gr3d m4gr3d force-pushed the update_godot_cpp_to_4_3_dev3 branch 2 times, most recently from b6830ff to a314291 Compare February 25, 2024 20:16
@BastiaanOlij
Copy link
Member

Is dev3 new enough for the json? I don't think that contains Malcolms and Davids latest changes around face and hand tracking?

Considering we're about to merge things that set our minimum version to whatever is build next, I wouldn't be against just taking the json from todays master.

@m4gr3d
Update the gdextension api json to Godot 4.3 dev3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
674773c
@m4gr3d m4gr3d force-pushed the update_godot_cpp_to_4_3_dev3 branch from a314291 to 674773c Compare February 26, 2024 03:52
@m4gr3d
Copy link
Collaborator Author

m4gr3d commented Feb 26, 2024

Is dev3 new enough for the json? I don't think that contains Malcolms and Davids latest changes around face and hand tracking?

Considering we're about to merge things that set our minimum version to whatever is build next, I wouldn't be against just taking the json from todays master.

Updated with the latest from master (commit godotengine/godot@81f3d43)

BastiaanOlij
BastiaanOlij approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, we should be able to rebase Davids and Malcolms projects and have them include updated json if needed (I think all upstream things were already merged so hopefully their changes are already in here)

@m4gr3d m4gr3d merged commit c63b6d1 into GodotVR:master Feb 26, 2024
7 checks passed
@m4gr3d m4gr3d deleted the update_godot_cpp_to_4_3_dev3 branch February 26, 2024 14:00
@dsnopek
Copy link
Collaborator

dsnopek commented Feb 26, 2024

dev4 is supposed to be released this week, so we could switch from master to dev4's JSON soon too.

@m4gr3d m4gr3d mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij

@dsnopek dsnopek

@Malcolmnixon Malcolmnixon

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m4gr3d @BastiaanOlij @dsnopek