-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Isolated Projects #1139
base: main
Are you sure you want to change the base?
Conversation
fa38161
to
17d7df6
Compare
4fcc4c3
to
2998d4d
Compare
https://scans.gradle.com/s/yz3nrgegbl3vc/tests/overview?outcome=FAILED
Lines 86 to 88 in 941e065
shadow/src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/UnusedTracker.kt Lines 51 to 61 in 7694a66
|
84b22a0
to
92a9f34
Compare
92a9f34
to
9348a7b
Compare
9348a7b
to
af858ec
Compare
/gemini review |
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces support for isolated projects in the Gradle Shadow plugin. This is achieved by adding a system property to the Gradle command-line arguments in the functional tests and updating the multi-project test case. The changes seem reasonable and well-targeted.
Merge Readiness
The changes look good and the pull request seems ready to be merged. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Refs #907.
https://docs.gradle.org/8.12/userguide/isolated_projects.html#how_do_i_use_it